Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: lb: return drop reasons from __lb4_rev_nat() #30410

Merged
merged 1 commit into from
Jan 24, 2024
Merged

bpf: lb: return drop reasons from __lb4_rev_nat() #30410

merged 1 commit into from
Jan 24, 2024

Conversation

julianwiedmann
Copy link
Member

Fix up some ctx_load_bytes() usage to return a drop reason, and not the raw kernel errno.

@julianwiedmann
bpf: lb: return drop reasons from __lb4_rev_nat()
59b6223 
Fix up some ctx_load_bytes() usage to return a drop reason, and not the
raw kernel errno.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added kind/bug This is a bug in the Cilium logic. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.12 area/loadbalancing Impacts load-balancing and Kubernetes service implementations needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Jan 24, 2024
@julianwiedmann julianwiedmann requested a review from a team as a code owner January 24, 2024 12:11
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann added this pull request to the merge queue Jan 24, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 24, 2024
Merged via the queue into cilium:main with commit 3932a4b Jan 24, 2024
62 of 63 checks passed
@julianwiedmann julianwiedmann deleted the 1.16-bpf-ctx-load-err branch January 24, 2024 14:15
@joamaki joamaki mentioned this pull request Jan 29, 2024
Merged
1 task
@joamaki joamaki mentioned this pull request Jan 30, 2024
Merged
7 tasks
@github-actions github-actions bot added the backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. label Jan 30, 2024
@joamaki joamaki mentioned this pull request Jan 30, 2024
Merged
28 tasks
@joamaki joamaki added the backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. label Jan 30, 2024
@joamaki joamaki removed the needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch label Jan 30, 2024
@github-actions github-actions bot added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 labels Jan 31, 2024
@joamaki joamaki mentioned this pull request Jan 31, 2024
Merged
17 tasks
@joamaki joamaki added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jan 31, 2024
@aanm aanm added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Jan 31, 2024
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Feb 7, 2024
This was referenced Feb 12, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markpash markpash markpash approved these changes

Assignees
No one assigned
Labels
area/loadbalancing Impacts load-balancing and Kubernetes service implementations backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
cilium v1.12.19
Status: Released
cilium v1.13.12
Status: Released
cilium v1.14.7
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julianwiedmann @markpash @joamaki @aanm