Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugtool: Deduplicate tc qdisc commands #32455

Merged

Conversation

pippolo84
Copy link
Member

The same tc commands to get information about queue discipline are repeated twice. Fix this deduplicating them.

Related: b13dc89 ("Bugtool: Add additional tc commands.")

Tested manually with a kind local cluster.

The same tc commands to get information about queue discipline are
repeated twice. Fix this deduplicating them.

Related: b13dc89 ("Bugtool: Add additional tc commands.")

Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
@pippolo84 pippolo84 added area/bugtool Impacts gathering of data for debugging purposes. release-note/misc This PR makes changes that have no direct user impact. labels May 10, 2024
@pippolo84 pippolo84 requested a review from a team as a code owner May 10, 2024 10:27
@pippolo84
Copy link
Member Author

Added @tommyp1ckles and @joestringer as reviewers since involved in the related PR as author and reviewer respectively.

Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mhofstetter mhofstetter removed the request for review from tommyp1ckles June 3, 2024 08:53
@pippolo84
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 3, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Jun 3, 2024
Merged via the queue into cilium:main with commit 123ac94 Jun 3, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bugtool Impacts gathering of data for debugging purposes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants