Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI for 32807 #33238

Conversation

nathanjsweet
Copy link
Member

@nathanjsweet nathanjsweet commented Jun 18, 2024

This is running a modified cilium CLI for #32807 . Specifically it is running cilium connectivity tests with port range tests.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 18, 2024
@github-actions github-actions bot added the sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. label Jun 18, 2024
@nathanjsweet
Copy link
Member Author

nathanjsweet commented Jun 18, 2024

Some of these will probably fail because they'll run port range tests on the downgrade. We'll see it in the logs, though.

Edit:
I was wrong, the downgrade tests did fine because of the CLIs feature check for port ranges.

@nathanjsweet
Copy link
Member Author

/test

@nathanjsweet nathanjsweet force-pushed the pr/nathanjsweet/CI-FOR-add-policy-port-range-mapping-3 branch from 02d247b to c86bcfb Compare June 21, 2024 18:13
The L4PolicyMap needs to index L4Filters by port
and protocol. With the introduction of port ranges
the golang builtin map type no longer suffices to
index the L4Filters. This commit refactors the
type to take a mix of named ports (which can never
have an EndPort) as well as simple port numbers,
and ranges. All usage of the type is rewritten
to account for the changes.

Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
- Remove EndPort warning
- Add CRD/API support for Endport.
- Modify the prefix logic for bpf map insertion
  to account for port ranges.
- Update all policymap calls that need to add port
  mask to the argument.
- Update the k8s network policy tests with a range
  look up test.
- Pass Endport to Envoy.

Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
@nathanjsweet nathanjsweet force-pushed the pr/nathanjsweet/CI-FOR-add-policy-port-range-mapping-3 branch from c86bcfb to 3360258 Compare June 21, 2024 18:29
@nathanjsweet
Copy link
Member Author

/test

@nathanjsweet
Copy link
Member Author

#32807 is merged!

@nathanjsweet nathanjsweet deleted the pr/nathanjsweet/CI-FOR-add-policy-port-range-mapping-3 branch June 24, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant