-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI for 32807 #33238
Closed
nathanjsweet
wants to merge
3
commits into
main
from
pr/nathanjsweet/CI-FOR-add-policy-port-range-mapping-3
Closed
CI for 32807 #33238
nathanjsweet
wants to merge
3
commits into
main
from
pr/nathanjsweet/CI-FOR-add-policy-port-range-mapping-3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Jun 18, 2024
github-actions
bot
added
the
sig/policy
Impacts whether traffic is allowed or denied based on user-defined policies.
label
Jun 18, 2024
Edit: |
/test |
nathanjsweet
force-pushed
the
pr/nathanjsweet/CI-FOR-add-policy-port-range-mapping-3
branch
from
June 21, 2024 18:13
02d247b
to
c86bcfb
Compare
The L4PolicyMap needs to index L4Filters by port and protocol. With the introduction of port ranges the golang builtin map type no longer suffices to index the L4Filters. This commit refactors the type to take a mix of named ports (which can never have an EndPort) as well as simple port numbers, and ranges. All usage of the type is rewritten to account for the changes. Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
- Remove EndPort warning - Add CRD/API support for Endport. - Modify the prefix logic for bpf map insertion to account for port ranges. - Update all policymap calls that need to add port mask to the argument. - Update the k8s network policy tests with a range look up test. - Pass Endport to Envoy. Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
nathanjsweet
force-pushed
the
pr/nathanjsweet/CI-FOR-add-policy-port-range-mapping-3
branch
from
June 21, 2024 18:29
c86bcfb
to
3360258
Compare
/test |
#32807 is merged! |
nathanjsweet
deleted the
pr/nathanjsweet/CI-FOR-add-policy-port-range-mapping-3
branch
June 24, 2024 21:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
sig/policy
Impacts whether traffic is allowed or denied based on user-defined policies.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is running a modified cilium CLI for #32807 . Specifically it is running cilium connectivity tests with port range tests.