Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test suite for netkit devices #1350

Closed
ti-mo opened this issue Feb 19, 2024 · 8 comments · Fixed by #1463
Closed

Add test suite for netkit devices #1350

ti-mo opened this issue Feb 19, 2024 · 8 comments · Fixed by #1463
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ti-mo
Copy link
Collaborator

ti-mo commented Feb 19, 2024

#1257 proposes to add support for attaching netkit programs, but we don't want to take on a dependency to vishvananda/netlink, even for testing. We've decided to drop the netkit tests for now, since the patchset is small and largely based on existing code, and kernel support isn't shipping in major distros for a while.

This issue is for 2 things:

@ti-mo ti-mo added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 19, 2024
@brlbil
Copy link
Contributor

brlbil commented Feb 20, 2024

@ti-mo I can work on adding netkit support to jsimonetti/rtnetlink

@ti-mo
Copy link
Collaborator Author

ti-mo commented Feb 20, 2024

@ti-mo I can work on adding netkit support to jsimonetti/rtnetlink

Perfect! Any ETA?

@brlbil
Copy link
Contributor

brlbil commented Feb 20, 2024

Not sure, I will try to push a PR upstream as soon as time allows.

@brlbil
Copy link
Contributor

brlbil commented Feb 26, 2024

@ti-mo we will need to wait for a new version of golang.org/x/sys package which should be released soon, at least according to their release history. Netkit related symbols are there but not in a tagged version yet.

@lmb
Copy link
Collaborator

lmb commented Apr 3, 2024

Hi @brlbil! Any news?

@brlbil
Copy link
Contributor

brlbil commented Apr 3, 2024

Hi @lmb We need some significant changes upstream. I will open an issue to discuss what would be the best way to proceed upstream.

@brlbil
Copy link
Contributor

brlbil commented Apr 4, 2024

@lmb @ti-mo I have created an issue upstream for discussion jsimonetti/rtnetlink#216

@brlbil
Copy link
Contributor

brlbil commented May 4, 2024

The PR to merge drivers including netkit, jsimonetti/rtnetlink#221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants