bpf2go: Fall back to default module name when debug.ReadBuildInfo is not available #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folbricht
force-pushed
the
buildinfo-default
branch
2 times, most recently
from
1189f83
to
3e0ea7d
Compare
|
Is bazel-contrib/rules_go#3090 the issue on the bazel side, that you are referring to? |
|
Yes, that's the one. There doesn't seem to be a solution for it yet. |
lmb
reviewed
Apr 11, 2023
|
I don't mind merging this to get bazel going again, but I want to be very clear that we don't support build systems other than the Go toolchain. Aka we won't check for breakage as you've discovered :) |
folbricht
force-pushed
the
buildinfo-default
branch
from
3e0ea7d
to
513adcb
Compare
|
Not supporting bazel is definitely fair. I'm just trying to set a reasonable default so things still work for anyone stuck with a build system that doesn't provide BuildInfo. |
bazel currently doesn't support debug.ReadBuildInfo. Default to a hardcoded module name to make things work again. Signed-off-by: folbrich <frank.olbricht@gmail.com>
lmb
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 223b7d7, bpf2go reads the module name from
debug.ReadBuildInfo(). Unfortunately this fails whenbpf2gois built with bazel which doesn't add the buildinfo (there is an open issue for it), causing a failure withdetermine current module: missing build info.This change sets a default if BuildInfo is not available.