sys: prevent clobbering existing entries in fd tracing registry #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
force-pushed
the
tb/no-clobber-fd-traces
branch
from
0a6f6d2
to
3e729b6
Compare
|
@lmb I'm not sure what your patch accomplishes, it just moves delete + remove finalizer a bit earlier in Close()? |
When introducing the FD leak detector we didn't take FD.Forget() into account, which triggers a spurious leak report when running individual iterator tests in package link. We didn't detect this because of another bug in the leak detector the following commit fixes. FD.Forget() is a really dodgy API which is only really used from tests. Refactor the tests to be less dodgy and remove FD.Forget. Also deal with closed FDs in File() properly. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
newFD() didn't check whether the stack it tried to insert for the given fd would overwrite an existing entry. Use LoadOrStore to check if a stack is already present, and panic if there is. Signed-off-by: Timo Beckers <timo@isovalent.com>
lmb
force-pushed
the
tb/no-clobber-fd-traces
branch
from
3e729b6
to
795cbe4
Compare
lmb
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newFD() didn't check whether the stack it tried to insert for the given fd would overwrite an existing entry.
Use LoadOrStore to check if a stack is already present, and panic if there is.