bpf2go: argument parsing unit test #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejedi
commented
Jun 7, 2023
mejedi
commented
Jun 7, 2023
mejedi
commented
Jun 7, 2023
| } | ||
| } | ||
|
|
||
| b2g.strip, err = exec.LookPath(b2g.strip) |
There was a problem hiding this comment.
Moving LookupPath out of parseArgs so that unit tests can pass arbitrary values in -strip flag.
mejedi
force-pushed
the
bpf2go-option-parsing-test
branch
from
ab6ce20
to
d8c68d5
Compare
mejedi
force-pushed
the
bpf2go-option-parsing-test
branch
from
d8c68d5
to
9a81965
Compare
lmb
requested changes
Jun 7, 2023
cmd/bpf2go/main.go
Outdated
| makeBase string | ||
| } | ||
|
|
||
| func (b2g *bpf2go) parseArgs(args []string) (err error) { |
There was a problem hiding this comment.
Nit: my preference is to have constructor like function as much as possible. How would you feel about newB2G(stdout io.Writer, pkg, outputDir string, args []string) (*b2g, error)?
mejedi
force-pushed
the
bpf2go-option-parsing-test
branch
from
9a81965
to
5091cf1
Compare
mejedi
commented
Jun 8, 2023
| } | ||
|
|
||
| input := args[1] | ||
| if _, err := os.Stat(input); os.IsNotExist(err) { |
There was a problem hiding this comment.
Moving os.Stat out of newB2G so that unit tests can pass arbitrary values.
Signed-off-by: Nick Zavaritsky <mejedi@gmail.com>
lmb
force-pushed
the
bpf2go-option-parsing-test
branch
from
5091cf1
to
3d8c466
Compare
|
Fixed a nit and rebased, thanks for refactoring this! |
lmb
approved these changes
Jun 8, 2023
|
@lmb thank you for the reviews! Any chance this could be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable unit tests for argument parsing in
bpf2go. This is in preparation for enabling bpf2go to take some arguments from the environment.The patch moves argument parsing from
runinto a separate function.