Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run-tests: support new packaging #1091

Merged
merged 2 commits into from
Sep 25, 2023
Merged

run-tests: support new packaging #1091

merged 2 commits into from
Sep 25, 2023

Conversation

lmb
Copy link
Collaborator

@lmb lmb commented Jul 12, 2023

ci-kernels are now packaged slightly differently:

  • Kernels are real tar files which also contain bpf_testmod
  • Kernels contain the arch in their name
  • Selftests don't contain bpf_testmod anymore

Update run-tests.sh to support the new format.

Needs: cilium/ci-kernels#42

@lmb lmb requested review from ti-mo and rgo3 July 12, 2023 17:18
run-tests.sh Outdated Show resolved Hide resolved
@lmb lmb requested a review from ti-mo July 20, 2023 07:49
@lmb lmb force-pushed the ci-kernel-packaging branch 3 times, most recently from f932c62 to f8cf8fa Compare August 10, 2023 13:21
@lmb
Copy link
Collaborator Author

lmb commented Aug 11, 2023

Seems like there is a new BTF bug in the 5.4 kernel build. Since we've had working 5.4 kernels at the same point release in the past I'm going to assume that it has something to do with how we build the kernel.

@lmb
Copy link
Collaborator Author

lmb commented Aug 11, 2023

The problem is that I updated pahole from 1.23 to 1.24. The new pahole encodes enum64 which the kernel doesn't understand.

@ti-mo ti-mo marked this pull request as draft August 21, 2023 08:07
@lmb lmb force-pushed the ci-kernel-packaging branch 5 times, most recently from 209cf62 to cfec14b Compare September 14, 2023 10:05
@ti-mo
Copy link
Collaborator

ti-mo commented Sep 15, 2023

@lmb Does this need our attention in the short term? I'll unsubscribe since I see it's marked as draft now.

Also, should we make this a Go tool instead of a script at some point?

@lmb lmb marked this pull request as ready for review September 19, 2023 08:13
@lmb
Copy link
Collaborator Author

lmb commented Sep 19, 2023

This is good to go now! I'm amazed it worked on GHA on the first try.

@lmb
Copy link
Collaborator Author

lmb commented Sep 22, 2023

@rgo3 @ti-mo PTAL.

ci-kernels are now packaged slightly differently:
* Kernels are real tar files which also contain bpf_testmod
* Kernels contain the arch in their name
* Selftests don't contain bpf_testmod anymore

Update run-tests.sh to support the new format.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Allow forcing the test seed via an environment variable when
running on other kernels. Correctly forward KERNEL_VERSION into
the VM.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
@lmb lmb force-pushed the ci-kernel-packaging branch 2 times, most recently from 2dc0d26 to b08e2ca Compare September 22, 2023 15:07
@lmb
Copy link
Collaborator Author

lmb commented Sep 22, 2023

We can merge cilium/ci-kernels#43 once this PR is in.

@lmb lmb merged commit d2b69be into cilium:main Sep 25, 2023
10 checks passed
@lmb lmb deleted the ci-kernel-packaging branch September 25, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants