elf: Add support for map struct typedef #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjmao
force-pushed
the
typedef-struct
branch
2 times, most recently
from
e7778b1
to
36e1eb1
Compare
lmb
requested changes
Sep 11, 2023
elf_reader.go
Outdated
| @@ -750,7 +750,12 @@ func (ec *elfCode) loadBTFMaps() error { | |||
| // Each Var representing a BTF map definition contains a Struct. | |||
| mapStruct, ok := v.Type.(*btf.Struct) | |||
There was a problem hiding this comment.
I think using https://pkg.go.dev/github.com/cilium/ebpf/btf#UnderlyingType here is more appropriate.
Yes, typedefs are used in some tracee ebpf code places. It uses libbpf and libbpfgo cgo wrapper. It's great that this was the only needed change to migrate such large ebpf code base to cilium/ebpf. |
|
I forgot: can you add a test in |
lmb
force-pushed
the
typedef-struct
branch
2 times, most recently
from
16841c3
to
ee441ef
Compare
Accept typedef'd structs in addition to regular anonymous structs. Fixes cilium#1126 Signed-off-by: anjmao <andzej@cast.ai>
Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
lmb
approved these changes
Oct 10, 2023
lmb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1126