Drop LLVM 7 and 9 in favor of 11, 14 and 17 #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've switched to self-hosted GHA runners. Signed-off-by: Timo Beckers <timo@isovalent.com>
Hardcoding clang-14 as the clang binary breaks the test suite on non-Debian-based distributions. There are likely better ways of doing this, but symlinking `clang` to your preferred toolchain should work. Signed-off-by: Timo Beckers <timo@isovalent.com>
This patch updates 'container-all' and 'container-shell' to specify BPF2GO_ envs using Docker's --env flags instead of arguments to 'make'. This allows the use of 'make generate' in the shell without manually having to specify bpf2go envs. Also extends the 'clean' target to find all .o and .elf files in the repo automatically instead of having to specify each subdir. Things are too spread out for that. Signed-off-by: Timo Beckers <timo@isovalent.com>
This is driven by a few reasons: - To reproducibly build C examples for our documentation, we want to rely on the libbpf-dev Debian package for <bpf/bpf_helpers.h>. Our current llvm toolchain image (Buster) ships a libbpf-dev package that doesn't contain this header, so we are encouraged to upgrade. - Bullseye, the next logical candidate, has LLVM packages for 11 all the way through 17. This means we would need to drop versions <11 from CI. - LLVM 7 came out in 2018, LLVM 9 in 2019. Given the development pace of BPF and most distributions dropping these versions long ago (Debian Bookworm ships LLVM 14), this seems reasonable. Signed-off-by: Timo Beckers <timo@isovalent.com>
ti-mo
force-pushed
the
tb/drop-clang-7-9
branch
from
ae348ad
to
a925d95
Compare
lmb
reviewed
Sep 28, 2023
| @@ -1 +1 @@ | |||
| 1694533004 | |||
| 1695896017 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed Semaphore config, made 'clang' the default binary in bpf2go tests, and made some assorted Makefile changes.