internal: fix reading auxv on 32-bit platforms #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
force-pushed
the
arm32-auxv
branch
3 times, most recently
from
687471a
to
c41af06
Compare
|
@hailwind could you give this a try on your arm32 environment? |
brycekahle
reviewed
Oct 2, 2023
brycekahle
approved these changes
Oct 10, 2023
|
@lmb Here's |
It turns out that the auxiliary vector has a platform specific size. Adjust the code to use uintptr to approximate "unsigned long" from C. auxv32le.bin is from an i686 Debian bookworm machine. Fixes cilium#1133 Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
|
Thanks for that, I had to change the code a little to be able to test 32bit on a 64bit host. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the auxiliary vector has a platform specific size. Adjust the code to use uintptr to approximate "unsigned long" from C.
Fixes #1133