asm: cleanups for v4 ISA #1214
Merged
asm: cleanups for v4 ISA #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Rejig the extended ALUOp a litte to make the encoding a little bit easier to understand. For MovSX we don't need to encode the width directly in the extended Op, so simplify the encoding to just be consecutive numbers. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
We don't need to extend the jump opcode yet, so we shouldn't reuse aluMask. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
The diagrams are aligned in a way that makes it difficult to figure out which field a bit belongs to. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
We currently rely on the low byte of OpCode to be a valid BPF opcode. Make this clearer by adding a method to OpCode. This allows us to reject invalid extended opcodes during marshaling. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
dylandreimerink
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asm: rename SMov to MovSX
asm: return an error when extended opcodes have offset
asm: make extended ALUOp easier to understand
asm: correct jumpMask
asm: fix OpCode doc comment
asm: refuse marshaling unknown extended opcodes