examples: avoid depending on internal packages #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Turns out |
ti-mo
changed the title
|
@ti-mo I think this should be good now |
lmb
force-pushed
the
tb/examples-internal-package
branch
from
c0fcb75
to
02ad905
Compare
|
@ti-mo can you fix the DCO violation? |
lmb
approved these changes
Mar 22, 2024
Technically this builds fine in CI, but these are supposed to function from outside the repo's ebpf module as well. These internal references were added after we removed the separate Go module from examples/. Signed-off-by: antoniomerlin <4397319+antoniomerlin@users.noreply.github.com> Signed-off-by: Timo Beckers <timo@isovalent.com>
ti-mo
force-pushed
the
tb/examples-internal-package
branch
from
02ad905
to
5f0cd39
Compare
ti-mo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically this builds fine in CI, but these are supposed to function from outside the repo's ebpf module as well. These internal references were added after we removed the separate Go module from examples/.
Supersedes #1288
Thanks @antoniomerlin for reporting!