syscalls: omit AttachType field in haveProgAttach #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a way to trigger CI if it hasn't started automatically? Looking on semaphore and it doesn't seem like this got picked up. |
|
CI seems currently buggy, see the thread on slack. |
lmb
reviewed
May 3, 2022
Discovered while running the test suite on kernel 4.14. With the addition BPF_PROG_ATTACH tests in package link, the haveProgAttach feature test was added, gated on 4.10. This helper uses the AttachType field, which sets the bpf_attr expected_attach_type field, which is only available as of 4.17. As probing CGroupSKB is sufficient, omit setting AttachType. This patch fixes the tests on kernels between 4.10 and 4.17. Signed-off-by: Timo Beckers <timo@isovalent.com>
Turns out I had a .gitignored UAPI header in my linux repo that contained And indeed, probing CGroupSKB is a representative proxy for |
ti-mo
changed the title
lmb
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while running the test suite on kernel 4.14.
With the addition BPF_PROG_ATTACH tests in package link, the haveProgAttach feature test was added, gated on 4.10. This helper uses the AttachType field, which sets the bpf_attr expected_attach_type field, available as of 4.17.
There are more issues to address for 4.14, but this patch fixes these tests on kernels between 4.10 and 4.17.
cc @rgo3