map: replace hacky unsafe.Pointer conversion with PROT_NONE page #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @nplanel |
One of our legacy code paths currently does a dodgy pointer conversion:
unsafe.Pointer(^uintptr(0))
This is (correctly) flagged by linters as being a bit bogus, since
unsafe.Pointer conversions do have an effect on the GC (I believe).
It also assumes that the highest address is never used.
Map an inaccessible page and use that instead of the bogus pointer.
This has the same effect but is much safer.
Signed-off-by: Lorenz Bauer <oss@lmb.io>
ti-mo
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our legacy code paths currently does a dodgy pointer conversion:
This is (correctly) flagged by linters as being a bit bogus, since unsafe.Pointer conversions do have an effect on the GC (I believe). It also assumes that the highest address is never used.
Map an inaccessible page and use that instead of the bogus pointer. This has the same effect but is much safer.
Signed-off-by: Lorenz Bauer oss@lmb.io