program: set name from object info for pinned file #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
requested changes
Feb 13, 2023
prog.go
Outdated
| @@ -783,7 +782,7 @@ func LoadPinnedProgram(fileName string, opts *LoadPinOptions) (*Program, error) | |||
| return nil, fmt.Errorf("info for %s: %w", fileName, err) | |||
| } | |||
|
|
|||
| return &Program{"", fd, filepath.Base(fileName), fileName, info.Type}, nil | |||
| return &Program{"", fd, info.Name, fileName, info.Type}, nil | |||
There was a problem hiding this comment.
I think this would leave > 4.11 && < 4.15 without a name. Maybe keep filepath.Base if !haveProgName()?
There was a problem hiding this comment.
Good point. I changed my patch to check for the necessary feature and fall back to the file base name, just as before.
When loading a program from a pinned file, the program name is set from the file name instead from the object info. This commit changes the procedure of setting the program name from the object info in case the feature is supported. It also adds tests for both support cases. Signed-off-by: Tobias Böhm <code@aibor.de>
lmb
approved these changes
Feb 20, 2023
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading a program from a pinned file, the program name is set from the file name instead from the object info.
This commit adds a test that expects the program name to be set from the object info and changes the procedure to set the name from the object info, which is present already and used to set the program type.
Signed-off-by: Tobias Böhm code@aibor.de