Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix expected fs type for /sys/kernel/debug/tracing #958

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Fix expected fs type for /sys/kernel/debug/tracing #958

merged 2 commits into from
Mar 6, 2023

Conversation

brycekahle
Copy link
Contributor

It turns out the subfolder /sys/kernel/debug/tracing is mounted separately with the tracefs fs type.

Trimmed output of mount:

debugfs on /sys/kernel/debug type debugfs (rw,nosuid,nodev,noexec,relatime)
tracefs on /sys/kernel/tracing type tracefs (rw,nosuid,nodev,noexec,relatime)
tracefs on /sys/kernel/debug/tracing type tracefs (rw,nosuid,nodev,noexec,relatime)

@brycekahle
Fix expected fs type for /sys/kernel/debug/tracing
8a818b1 
Signed-off-by: Bryce Kahle <bryce.kahle@datadoghq.com>
@brycekahle brycekahle mentioned this pull request Mar 3, 2023
Merged
lmb
lmb requested changes Mar 6, 2023
View reviewed changes
internal/statfs.go Outdated Show resolved Hide resolved
internal/statfs_test.go Outdated Show resolved Hide resolved
@brycekahle
Use unix constants
b60841a 
Signed-off-by: Bryce Kahle <bryce.kahle@datadoghq.com>
@brycekahle brycekahle force-pushed the bryce.kahle/tracefs-fstype-fix branch from 7f4f896 to b60841a Compare March 6, 2023 17:30
lmb
lmb approved these changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@lmb lmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I can't push a fixup since I can't access datadog/ebpf. Please create the PR from a personal repo next time.

@lmb lmb added the bug Something isn't working label Mar 6, 2023
@brycekahle
Copy link
Contributor Author

@lmb will do. What fixup did you want?

@lmb lmb merged commit 98ac6db into cilium:master Mar 6, 2023
@brycekahle brycekahle deleted the bryce.kahle/tracefs-fstype-fix branch March 13, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmb lmb lmb approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brycekahle @lmb