Add error case for creating unspecified map type. #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-mo
reviewed
Mar 11, 2023
lmb
reviewed
Mar 13, 2023
tommyp1ckles
force-pushed
the
pr/tp/improve-unspec-bpf-map-create-error
branch
2 times, most recently
from
1e918a8
to
9e0f062
Compare
When creating a new map, if the the map type is unspecified (i.e. BPF_MAP_TYPE_UNSPEC) then the call to create the map will fail with EINVAL and the following Go error is returned due to the btf file descriptor being zerod out: ...: map create: ... (without BTF k/v) Instead, this will now immediately check if a map is unspecified and return an approriate error. Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
tommyp1ckles
force-pushed
the
pr/tp/improve-unspec-bpf-map-create-error
branch
from
9e0f062
to
63ab8f8
Compare
tommyp1ckles
requested review from
lmb and
ti-mo
and removed request for
lmb and
ti-mo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new map, if the the map type is unspecified (i.e. BPF_MAP_TYPE_UNSPEC) then the call to create the map will fail with EINVAL and the following Go error is returned due to the btf file descriptor being zerod out:
...: map create: ... (without BTF k/v)
Instead, upon failure to create me, this will now check if the map type was set to unspecified and return a relevant error.