flow: add support for trace context, drop support for Go 1.17 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolinh
force-pushed
the
pr/rolinh/trace-context
branch
from
115c43b
to
2727973
Compare
The upcoming version of Cilium uses the net/netip package which was added to Go 1.18. This means that older versions of Go are not supported anymore. Also, since Go 1.19 is out, Go 1.17 is EOL. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Updating Cilium means pulling latest API changes that add trace context information to Hubble flows. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
By default, a flow contains a trace context with a probability of 0.1. In theory, we should tie trace context to L7 flows only but the library doesn't generate L7 flows (yet). Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
The WithDropReasonNonDropProbability drop reason option incorrectly set the probability to 1.0 for any provided value greater than 0. This is incorrect, the intent was to bound the provided value between 0 and 1. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
force-pushed
the
pr/rolinh/trace-context
branch
from
2727973
to
e510380
Compare
rolinh
changed the title
chancez
reviewed
Oct 7, 2022
| // fakeTraceID generates a fake trace ID. See the W3C Trace Context | ||
| // specification for details: | ||
| // https://www.w3.org/TR/trace-context/#trace-id | ||
| func fakeTraceID() string { |
There was a problem hiding this comment.
Any reason we don't just use an actual library to generate a traceID?
There was a problem hiding this comment.
I just thought it's not needed in this context (generating fake data). The trace ID is simply a 16-byte array where the only invalid value is all bytes as zero so something easy enough to generate. There are considerations to have when generating trace IDs for a "real" use-case (see this document) but I don't think it applies here.
chancez
approved these changes
Oct 7, 2022
michi-covalent
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.