Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renovate: bump Go version for GHA in stable branch #1068

Closed
wants to merge 1 commit into from
Closed

renovate: bump Go version for GHA in stable branch #1068

wants to merge 1 commit into from

Conversation

kaworu
Copy link
Member

@kaworu kaworu commented Jun 7, 2023

No description provided.

@kaworu
renovate: bump Go version for GHA in stable branch
da86e6c 
Signed-off-by: Alexandre Perrin <alex@isovalent.com>
@kaworu kaworu added kind/enhancement This would improve or streamline existing functionality. 🤖 area/CI Impacts the testing / continuous integration testing of the project. labels Jun 7, 2023
@kaworu kaworu requested a review from a team as a code owner June 7, 2023 12:39
@kaworu kaworu requested review from rolinh and removed request for a team June 7, 2023 12:39
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label PR is blocked until the release note is set label Jun 7, 2023
@kaworu kaworu mentioned this pull request Jun 7, 2023
Merged
@kaworu kaworu added the release-note/misc This PR makes changes that have no direct user impact. label Jun 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label PR is blocked until the release note is set label Jun 7, 2023
gandro
gandro reviewed Jun 7, 2023
View reviewed changes
.github/renovate.json5
Comment on lines +202 to +205
"allowedVersions": "<=1.19",
"matchBaseBranches": [
"v0.11"
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like it belongs to the regex manager. Shouldn't his be part of of a packageGroup?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion #1069 should be enough. We already do have a packageGroup rule that limits the allowed Go versions in the v0.11 branch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gandro I tried to figure this out from the renovate documentation but I'm struggling 😅 marking as draft, let's merge #1069 and see if it's enough!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked 🎉 https://github.com/cilium/hubble/compare/f76199977d0b8fb0f32acd8a61f4a88f2fd7f2ea..a7b9f90623a3a13804011d69b75406aed4669030

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 7, 2023
@gandro gandro removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 7, 2023
@rolinh rolinh removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 7, 2023
@kaworu kaworu marked this pull request as draft June 7, 2023 13:18
@kaworu kaworu added the dont-merge/blocked PR/issue blocked by an external factor (be that PR, issue, or else) label Jun 7, 2023
@kaworu kaworu closed this Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro left review comments

@rolinh rolinh rolinh approved these changes

Assignees
No one assigned
Labels
🤖 area/CI Impacts the testing / continuous integration testing of the project. dont-merge/blocked PR/issue blocked by an external factor (be that PR, issue, or else) kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaworu @gandro @rolinh