Display server provided flows rate #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change switches from reporting the calculate `Flows Per Second` field to the more up-to-date `flowsRate` field provided by the server. If the server doesn't provide the flows rate, we fall back to calculating the flows per second using uptime and seen flows. closes: cilium#952 Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
lambdanis
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change switches from reporting the calculate
Flows Per Secondfield to the more up-to-dateflowsRatefield provided by the server.If the server doesn't provide the flows rate, we fall back to calculating the flows per second using uptime and seen flows.
closes: #952