cmd/observe: match only Hubble-specific part of error in Test_getFlowsRequestWithInvalidRawFilters #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sRequestWithInvalidRawFilters protobuf-go deliberately introduces instability into their error message strings to discourage users from matching on error strings [1]. This breaks Test_getFlowsRequestWithInvalidRawFilters in unpredictable ways. This was e.g. the case for #650 where the error message was updated. Due to the instability, he test again broke on #653 [1] https://github.com/protocolbuffers/protobuf-go/blob/01b51b4f96e6f04345af6153c1b69345f8e075b9/internal/errors/errors.go#L26-L34 Make the test resilient against this behavior by matching only against the Hubble-specific part of the error string. Fixes: 18dbc6c ("observe: Add --allowlist / --denylist flags") Fixes: 771bb4a ("vendor: Bump github.com/cilium/cilium to v1.11.0-rc3") Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
requested review from
a team and
jrfastab
and removed request for
a team
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
tklauser
added
needs-backport/0.9
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
added
the
ready-to-merge
tklauser
added
backport-pending/0.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protobuf-go deliberately introduces instability into their error message
strings to discourage users from matching on error strings [1]. This
breaks Test_getFlowsRequestWithInvalidRawFilters in unpredictable ways.
This was e.g. the case for #650
where the error message was updated. Due to the instability, he test
again broke on #653
[1] https://github.com/protocolbuffers/protobuf-go/blob/01b51b4f96e6f04345af6153c1b69345f8e075b9/internal/errors/errors.go#L26-L34
Make the test resilient against this behavior by matching only against
the Hubble-specific part of the error string.
Fixes: 18dbc6c ("observe: Add --allowlist / --denylist flags")
Fixes: 771bb4a ("vendor: Bump github.com/cilium/cilium to v1.11.0-rc3")