cmd/config: ensure that the configuration directory exist #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolinh
added
the
release-note/bug
rolinh
requested review from
a team and
jrfastab
and removed request for
a team
`hubble config set ...` fails to save the configuration file if the configuration directory doesn't already exist thus requiring the user to create it beforehand. To address this issue, this commit ensures that the configuration directory exists when `config set` is invoked by creating it when necessary. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
force-pushed
the
pr/rolinh/fix-config-dir-missing
branch
from
18a63b6
to
e23d170
Compare
kaworu
approved these changes
Feb 28, 2022
gandro
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hubble config set ...fails to save the configuration file if theconfiguration directory doesn't already exist thus requiring the user to
create it beforehand. To address this issue, this commit ensures that
the configuration directory exists when
config setis invoked bycreating it when necessary.
Closes: #677