Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for less granular time formats #707

Merged
merged 2 commits into from
Apr 22, 2022

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Apr 21, 2022

No description provided.

@rolinh rolinh added ⌨️ area/cli Impacts the command line interface of any command in the repository. 🌟 kind/feature This introduces new functionality. release-note/minor This PR introduces functionality that users may find relevant to operating Hubble. labels Apr 21, 2022
@rolinh rolinh requested review from a team and jrfastab and removed request for a team April 21, 2022 12:59
pkg/time/time.go Outdated Show resolved Hide resolved
pkg/time/time.go Outdated Show resolved Hide resolved
pkg/time/time_test.go Show resolved Hide resolved
pkg/time/time_test.go Show resolved Hide resolved
cmd/observe/flows.go Show resolved Hide resolved
@rolinh rolinh force-pushed the pr/rolinh/year-month-day-time-format branch from da19831 to f404afc Compare April 21, 2022 20:14
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh force-pushed the pr/rolinh/year-month-day-time-format branch from f404afc to 5155816 Compare April 21, 2022 20:17
@rolinh rolinh requested a review from kaworu April 21, 2022 20:18
Copy link
Collaborator

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rolinh, patch LGTM now.

@rolinh rolinh merged commit 3421e33 into master Apr 22, 2022
@rolinh rolinh deleted the pr/rolinh/year-month-day-time-format branch April 22, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌨️ area/cli Impacts the command line interface of any command in the repository. 🌟 kind/feature This introduces new functionality. release-note/minor This PR introduces functionality that users may find relevant to operating Hubble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants