cmd/observe: Add --first to support querying for earlier flows and events #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
@chancez I'd like to get this into the next release. Now that the upstream PR has been merged, do you think you could rebase this? |
rolinh
added
the
needs-rebase
|
@gandro I was waiting for a new release branch to be cut that has my changes so I can update the reference to vendor. Do we have a branch I can update the vendored cilium/cilium to yet? |
|
@chancez No need for a new release branch to be cut. Just pick latest master, we'll take care of updating the dependency to the next RC once it's out. |
chancez
force-pushed
the
pr/chancez/hubble_observe_first
branch
from
fd65e67
to
e38d82d
Compare
|
How I tested: I ran the following two commands at "roughly the same time" and they typically contained the exact same 5 flows (if I ran them "at the same time"). This required building cilium & Hubble-relay from master and installing cilium with those images. |
gandro
added
⌨️ area/cli
needs-rebase
rolinh
requested changes
May 31, 2022
cmd/observe/flows.go
Outdated
| @@ -198,6 +198,7 @@ more.`, | |||
| selectorFlags := pflag.NewFlagSet("selectors", pflag.ContinueOnError) | |||
| selectorFlags.BoolVar(&selectorOpts.all, "all", false, "Get all flows stored in Hubble's buffer") | |||
| selectorFlags.Uint64Var(&selectorOpts.last, "last", 0, fmt.Sprintf("Get last N flows stored in Hubble's buffer (default %d)", defaults.FlowPrintCount)) | |||
| selectorFlags.Uint64Var(&selectorOpts.first, "first", 0, fmt.Sprintf("Get last N flows stored in Hubble's buffer (default %d)", defaults.FlowPrintCount)) | |||
There was a problem hiding this comment.
Suggested change
| selectorFlags.Uint64Var(&selectorOpts.first, "first", 0, fmt.Sprintf("Get last N flows stored in Hubble's buffer (default %d)", defaults.FlowPrintCount)) | |
| selectorFlags.Uint64Var(&selectorOpts.first, "first", 0, fmt.Sprintf("Get first N flows stored in Hubble's buffer (default %d)", defaults.FlowPrintCount)) |
There was a problem hiding this comment.
Oof, good catch. I'm embarrassed by that one.
…ents Also updates vendored cilium/cilium to pickup new First field in observer APIs Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
chancez
force-pushed
the
pr/chancez/hubble_observe_first
branch
from
e38d82d
to
8cd73fa
Compare
rolinh
approved these changes
May 31, 2022
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on cilium/cilium#19819