improve cli help text for service filtering #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
kaworu
added
📄 area/documentation
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
Thank you @ILLIDOM, could you squash the two commit into one please 🙏? |
The way the service field in Hubble flows has been implemented so far is that it only works if the destination IP is the service ClusterIP. This makes the following lines from hubble observe --help misleading: --from-service filter Show all flows originating in the given service ([namespace/]<svc-name>). If namespace is not provided, 'default' is used --service filter Show all flows related to the given service ([namespace/]<svc-name>). If namespace is not provided, 'default' is used --to-service filter Show all flows terminating in the given service ([namespace/]<svc-name>). If namespace is not provided, 'default' is used This patch changes the help message to address the inaccuracy described above. Fixes: cilium#713 Signed-off-by: Dominique Illi illi.dominique.v@gmail.com
ILLIDOM
force-pushed
the
pr/hubble-cli-help-service-filtering
branch
from
0cb882a
to
8e9d612
Compare
|
@kaworu I have done a |
kaworu
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the service field in Hubble flows has been implemented so far is that it only works if the destination IP is the service ClusterIP. This makes the following lines from hubble observe --help misleading:
--from-service filter Show all flows originating in the given service ([namespace/]). If namespace is not provided, 'default' is used
--service filter Show all flows related to the given service ([namespace/]). If namespace is not provided, 'default' is used
--to-service filter Show all flows terminating in the given service ([namespace/]). If namespace is not provided, 'default' is used
This patch changes the help message to address the inaccuracy described above.
Fixes: #713
Signed-off-by: Dominique Illi illi.dominique.v@gmail.com