Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Deprecate -o json, recommend -o jsonpb instead #738

Merged
merged 1 commit into from
Jun 7, 2022

Commits on Jun 7, 2022

  1. cli: Deprecate -o json, recommend -o jsonpb instead

    The `-o json` output had been added to Hubble very early, when we
    assumed that all relevant information would be contained in the `Flow`
    protobuf message. Hubble has however since gained the `-o jsonpb`
    output, which contains additional information such as the node name
    which produced the network flow.
    
    More importantly, `-o json` cannot be piped into `hubble observe` for
    additional filtering, therefore further limiting its usability. To avoid
    users accidentally using `-o json` instead of the likely more correct
    `-o jsonpb`, this commit deprecates `-o json` and prints a warning to
    stderr whenever it is used.
    
    This allows us to fully remove `-o json` in a future release.
    
    Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
    gandro committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    379e2fb View commit details
    Browse the repository at this point in the history