Do not fail if unable to provide client certificate when requested #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancez
added
kind/enhancement
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
When a server requests a client certificate, it's not always required, so do not fail if a client certificate was not configured, instead let the server reject the request instead, in case it supports other authentication methods. Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
chancez
force-pushed
the
pr/chancez/client_cert_optional
branch
from
506615f
to
7ffab64
Compare
chancez
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
chancez
added
release-note/misc
kaworu
approved these changes
Apr 27, 2023
rolinh
approved these changes
Apr 27, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
the button is green. therefore i click. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a server requests a client certificate, it's not always required, so do not fail if a client certificate was not configured, instead let the server reject the request instead, in case it supports other authentication methods.