podinfo: Populate workload info #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
force-pushed
the
pr/michi/workload
branch
from
894535d
to
b0bc6d5
Compare
michi-covalent
added
the
release-note/misc
michi-covalent
force-pushed
the
pr/michi/workload
branch
5 times, most recently
from
c493ba0
to
045a3a5
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
michi-covalent
force-pushed
the
pr/michi/workload
branch
2 times, most recently
from
3d8f765
to
d058504
Compare
lambdanis
reviewed
Sep 20, 2023
- Add WorkloadType and WorkloadObject fields to PodInfo. - Export workload.GetWorkloadMetaFromPod() function so that the operator can call it to set WorkloadType and WorkloadObject fields. - Update equal() function to take these fields into account. I opted for defining a new WorkloadObjectMeta type instead of using metav1.ObjectMeta to avoid generating unnecessary "unknown field" log messages. See [1] for additional context. [1]: kubernetes-sigs/controller-tools#448 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/workload
branch
from
d058504
to
d8dc753
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can call it to set WorkloadType and WorkloadObject fields.
I opted for defining a new WorkloadObjectMeta type instead of using
metav1.ObjectMeta to avoid generating unnecessary "unknown field" log
messages. See 1 for additional context.
Signed-off-by: Michi Mutsuzaki michi@isovalent.com