k8s: Fix CRDs Go code generation #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a9c509f. The reverted commit replaced execution of deprecated scripts with k8s.io/code-generator/kube_codegen.sh. However, kube_codegen.sh doesn't generate code on its own, but rather defines helper functions. To migrate to kube_codegen.sh we'll need to call these functions from another script. Additionally, it'll change with version 1.30 of k8s libraries - that's why I opted to simply revert the change for now. When k8s libraries are updated to 1.30, the code generation scripts should be updated too. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
lambdanis
added
kind/bug
CRD Go code generation wasn't working recently, so some changes to CRDs aren't reflected in the generated helpers. This commit fixes that. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
lambdanis
force-pushed
the
pr/lambdanis/fix-make-crds
branch
from
f3a2190
to
a1961a7
Compare
|
I can create an issue so that we don't forget to update, to note that it's marked as deprecated if you want :) |
|
@mtardy sure, feel free to open an issue. K8s dependencies are generally updated together with cilium/cilium, right? |
yet it should be for minor versions. |
|
Feel free to edit the content if it's unclear #2349. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit a9c509f replaced execution of deprecated scripts with
k8s.io/code-generator/kube_codegen.sh. However, kube_codegen.sh doesn't generate
code on its own, but rather defines helper functions. To migrate to
kube_codegen.sh we'll need to call these functions from another script.
Additionally, it'll change with version 1.30 of k8s libraries - that's why I
opted to simply revert the change for now. When k8s libraries are updated to
1.30, the code generation scripts should be updated too.