add support for bpf_attr type #246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpapagian
reviewed
Jul 19, 2022
There was a problem hiding this comment.
Thanks!
Some initial comments:
- You should also commit the generated files (i.e. inside
api/directory typemaketo generate grpc files and then in the top-level directorymake codegen && make generate). - It seems that it lacks proper code formatting (i.e.
make format). - In
crds/examples/there are a couple of examples on how to use various types. It would be great if you can add an example there as well. - It would be also great if we can have a simple unit test for that (but this can be also done as a followup into a separate PR).
sarahfujimori
force-pushed
the
pr/sarahfujimori/add_bpf_attr
branch
from
f5b362a
to
22d27a7
Compare
tpapagian
reviewed
Jul 21, 2022
This patch allows us to collect name, program type, and instruction count of eBPF programs when they are verified. Signed-off-by: Sarah Fujimori <sarah.fujimori@isovalent.com>
sarahfujimori
force-pushed
the
pr/sarahfujimori/add_bpf_attr
branch
from
22d27a7
to
1dc5839
Compare
|
We can ignore the checkpatch job for now, that warning is a false positive which I am fixing here #258 |
|
@sarahfujimori Mind running |
|
needs a rebase as well.. |
|
see #275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows us to collect name, program type, and instruction
count of eBPF programs when they are verified.
Signed-off-by: Sarah Fujimori sarah.fujimori@isovalent.com