-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename NotifyKiller to Enforcer in docs #2518
Conversation
Signed-off-by: michalzarsm <michalzarsm@gmail.com>
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this page of the doc I think it's good!
I'll note there are still some references globally in docs that could be changed and could be added in the issue: it's mostly docs in the tracing_policy_types.go
and .proto
that gets propagated through generation.
rg -g '!.git' -g '!vendor' -i killer
You get an output similar to this:
pkg/api/tracingapi/client_kprobe.go
27: ActionNotifyKiller = 12
install/kubernetes/tetragon/crds-yaml/cilium.io_tracingpolicies.yaml
95: description: A killer spec.
install/kubernetes/tetragon/crds-yaml/cilium.io_tracingpoliciesnamespaced.yaml
95: description: A killer spec.
patch
40:+ # for killer tests on 32 bits syscall values
docs/content/en/docs/reference/grpc-api.md
677:| KPROBE_ACTION_NOTIFYENFORCER | 13 | NotifyEnforcer action notifies killer sensor. |
pkg/k8s/apis/cilium.io/client/crds/v1alpha1/cilium.io_tracingpolicies.yaml
95: description: A killer spec.
pkg/k8s/apis/cilium.io/client/crds/v1alpha1/cilium.io_tracingpoliciesnamespaced.yaml
95: description: A killer spec.
contrib/upgrade-notes/v1.1.0.md
15:* Killer is renamed to enforcer. If using policies with killers, you need to replace `killers` with `enforcers` and `action: NotifyKiller` with `action: NotifyEnforcer`.
pkg/k8s/apis/cilium.io/v1alpha1/tracing_policy_types.go
105: // A killer spec.
bpf/process/types/basic.h
110: ACTION_NOTIFY_KILLER = 12,
2217: case ACTION_NOTIFY_KILLER:
pkg/grpc/tracing/tracing.go
63: case tracingapi.ActionNotifyKiller:
api/v1/tetragon/tetragon.pb.go
58: // NotifyEnforcer action notifies killer sensor.
api/v1/tetragon/tetragon.proto
464: // NotifyEnforcer action notifies killer sensor.
api/v1/README.md
1114:| KPROBE_ACTION_NOTIFYENFORCER | 13 | NotifyEnforcer action notifies killer sensor. |
Changed all occurrences of "killer" to enforcer in selectors.md
Fixes: #2517