Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tetragon_errors_total{type="handler_error"} metric #2862

Merged

Conversation

lambdanis
Copy link
Contributor

It was duplicating tetragon_handler_errors_total.

Part of #2785

@lambdanis lambdanis added area/metrics Related to prometheus metrics release-note/minor This PR introduces a minor user-visible change labels Sep 2, 2024
@lambdanis lambdanis requested review from mtardy and a team as code owners September 2, 2024 11:12
Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 66c3ff8
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/66d5c92bb5e0b40008dcce90
😎 Deploy Preview https://deploy-preview-2862--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lambdanis lambdanis force-pushed the pr/lambdanis/handler-errors-metric branch from b3ddf95 to b6ba011 Compare September 2, 2024 14:03
@lambdanis lambdanis added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 2, 2024
It was duplicating tetragon_handler_errors_total.

Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
@lambdanis lambdanis force-pushed the pr/lambdanis/handler-errors-metric branch from b6ba011 to 66c3ff8 Compare September 2, 2024 14:18
@olsajiri
Copy link
Contributor

olsajiri commented Sep 2, 2024

curious, can we still get the total number, like all the opcodes/err summed up?

@lambdanis
Copy link
Contributor Author

curious, can we still get the total number, like all the opcodes/err summed up?

@olsajiri Yes, when querying metrics with PromQL you typically do something like

sum(rate(tetragon_bpf_missed_events_total[5m]))

In case of tetragon_errors_total metric however, such aggregation doesn't make much sense, because this metric is collecting various unrelated errors and non-errors. That's why I'm splitting it up, so that metrics queries are more meaningful.

@lambdanis lambdanis merged commit 4032590 into cilium:main Sep 2, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics Related to prometheus metrics kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note/minor This PR introduces a minor user-visible change
Projects
Development

Successfully merging this pull request may close these issues.

5 participants