Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace missing process info metric #2863

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

lambdanis
Copy link
Contributor

Replace tetragon_errors_total{type="event_missing_process_info"} metric with tetragon_events_missing_process_info_total.

Part of #2785

@lambdanis lambdanis added area/metrics Related to prometheus metrics release-note/minor This PR introduces a minor user-visible change labels Sep 2, 2024
@lambdanis lambdanis requested review from mtardy and a team as code owners September 2, 2024 11:45
@lambdanis lambdanis changed the title Replace missing process info metrics Replace missing process info metric Sep 2, 2024
Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 1041ffb
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/66d5c7c480641a000819c1fb
😎 Deploy Preview https://deploy-preview-2863--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@olsajiri olsajiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, could be probably just one change, but lgtm, thanks

It's duplicating tetragon_errors_total{type="event_missing_process_info"}, which
will be removed in a follow up commit.

Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
It has been replaced by more intuitive metric
tetragon_events_missing_process_info_total

Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
@lambdanis lambdanis force-pushed the pr/lambdanis/missing-process-info branch from 2607120 to 1041ffb Compare September 2, 2024 14:12
@lambdanis lambdanis added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 2, 2024
@lambdanis lambdanis merged commit 15ae54a into main Sep 2, 2024
29 checks passed
@lambdanis lambdanis deleted the pr/lambdanis/missing-process-info branch September 2, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics Related to prometheus metrics kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note/minor This PR introduces a minor user-visible change
Projects
Development

Successfully merging this pull request may close these issues.

5 participants