Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Std improvements #104

Merged
merged 2 commits into from
Jun 26, 2022
Merged

Std improvements #104

merged 2 commits into from
Jun 26, 2022

Conversation

rene-post
Copy link
Contributor

Describe Request

Volatility: Standard Deviation (Std)

Change Type

Performance improvements.

@codecov-commenter
Copy link

Codecov Report

Merging #104 (1e3b406) into master (6b80892) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   57.35%   57.42%   +0.06%     
==========================================
  Files          13       13              
  Lines        1217     1219       +2     
==========================================
+ Hits          698      700       +2     
  Misses        511      511              
  Partials        8        8              
Impacted Files Coverage Δ
volatility_indicators.go 55.96% <100.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b80892...1e3b406. Read the comment docs.

@cinar
Copy link
Owner

cinar commented Jun 26, 2022

Thank you very much for sending it! It looks great. If you don't mind, I'll rename with Std function as StdFromSma and I'll have the Std to use that, so that Std can still be used without the sma. This is now very well optimized, thank you!

@cinar cinar merged commit b2f3489 into cinar:master Jun 26, 2022
@cinar
Copy link
Owner

cinar commented Jun 26, 2022

Available in release v1.2.23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants