Improve handling of implicitly built Criteria #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…These are now unnecessary since the Criteria interface is implemented by BuiildableState
This reverts commit 367400b.
jtnelson
pushed a commit
that referenced
this pull request
Jun 24, 2019
* Page builder * Spotless apply * Moved files to pagination package * Added abstract methods definitions * Added thrift methods * Spotless apply * Revert pagination merge * Removed pagination methods * Splotless apply * DO NOT MERGE: slight refactor to Order class * Improve handling of implicitly built Criteria (#366) * Refactor Criteria to be an interface that applies to all buildable states * Remove driver methods that took a generic Object criteria parameter. These are now unnecessary since the Criteria interface is implemented by BuiildableState * update changelog * fix formatting * Deprecate Criteria#getCclString in favor of Criteria#ccl * make method final * Revert "make method final" This reverts commit 367400b. * add method stubs that take an Order specification * fix formatting * refactor Order logic to accept timestamps * add constructs to convert between java and thrift order types * add implementation stubs for driver methods * generate plugin support for Order paraemter * fix a bug in PrettyLinkedTableMap when printing null values * add ManagedConcourseServer impl * interim state * doc update * checkpoint * fix formatting * doc update * set version number to 0.10.0 * another checkpoint * fix formatting * set accent4j dependency to release version * new client side data collections must use linked collections to preserve order returned from server * fix formatting * use null to signal that Order.none() should be used * Fix the project specicif gradlew scripts to properly accept flags * CON-649: Prevent unreadable database state when stopping Concourse Server in the middle of indexing (#367) * CON-649: Add unit test to attempt a repro * add FileSystem#ls method that takes a Path paramter * add factory methods that take a Path parameter * detect when a Block is malformed (e.g. partially written to disk) and throw an Exception * handle malformed Blocks * fix formatting * skip tests * update changelog * CON-654: Make background tasks responsive to Database shutdown request (#369) * set version number to 0.10.0 * CON-654: Make database async tasks (loading, accepting and syncing writes) responsive to stop request. Use traditional ExecutorService to signal that background threads should stop when Database is stopping. Also use a thread factory that doesn't categorize async threads as daemon threads * compiler hints * Fix unit test failure * update changelog * update unit test * allow ete tests to run during build * fix formatting * Revert "allow ete tests to run during build" This reverts commit bf58928. * fix gradlew script * Fix the project specicif gradlew scripts to properly accept flags * make unit test more meaningful * fix formatting * Rename ResultIndex => DataIndex and ResultProjection => DataProjection * make class private * Use constant for null order * add integration test for Order * add more integration tests
jtnelson
added a commit
that referenced
this pull request
Jun 29, 2019
* CON-637: Create Order Builder (#360) * created Order Builder * Removed where chained call * Fixed Order * spotless apply * Renamed classes * Moved files to lang.sort package * Added Sort alias for Order * Spotless apply * Readded removed line * SpotlessApply * Refactor Order builder a bit * doc updates * fix formatting * add some syntactic sugar * fix formatting * CON-640: Concourse Drive Query Methods (#363) * Page builder * Spotless apply * Moved files to pagination package * Added abstract methods definitions * Added thrift methods * Spotless apply * Revert pagination merge * Removed pagination methods * Splotless apply * DO NOT MERGE: slight refactor to Order class * Improve handling of implicitly built Criteria (#366) * Refactor Criteria to be an interface that applies to all buildable states * Remove driver methods that took a generic Object criteria parameter. These are now unnecessary since the Criteria interface is implemented by BuiildableState * update changelog * fix formatting * Deprecate Criteria#getCclString in favor of Criteria#ccl * make method final * Revert "make method final" This reverts commit 367400b. * add method stubs that take an Order specification * fix formatting * refactor Order logic to accept timestamps * add constructs to convert between java and thrift order types * add implementation stubs for driver methods * generate plugin support for Order paraemter * fix a bug in PrettyLinkedTableMap when printing null values * add ManagedConcourseServer impl * interim state * doc update * checkpoint * fix formatting * doc update * set version number to 0.10.0 * another checkpoint * fix formatting * set accent4j dependency to release version * new client side data collections must use linked collections to preserve order returned from server * fix formatting * use null to signal that Order.none() should be used * Fix the project specicif gradlew scripts to properly accept flags * CON-649: Prevent unreadable database state when stopping Concourse Server in the middle of indexing (#367) * CON-649: Add unit test to attempt a repro * add FileSystem#ls method that takes a Path paramter * add factory methods that take a Path parameter * detect when a Block is malformed (e.g. partially written to disk) and throw an Exception * handle malformed Blocks * fix formatting * skip tests * update changelog * CON-654: Make background tasks responsive to Database shutdown request (#369) * set version number to 0.10.0 * CON-654: Make database async tasks (loading, accepting and syncing writes) responsive to stop request. Use traditional ExecutorService to signal that background threads should stop when Database is stopping. Also use a thread factory that doesn't categorize async threads as daemon threads * compiler hints * Fix unit test failure * update changelog * update unit test * allow ete tests to run during build * fix formatting * Revert "allow ete tests to run during build" This reverts commit bf58928. * fix gradlew script * Fix the project specicif gradlew scripts to properly accept flags * make unit test more meaningful * fix formatting * Rename ResultIndex => DataIndex and ResultProjection => DataProjection * make class private * Use constant for null order * add integration test for Order * add more integration tests * don't run spotless task * try again: * more unit tests * more unit tests and fixes * add annotations back * add delegate methods for Timestr * more impl * formatting * docs * fix some bugs * implement findCriteriaOrder * remove annotations * implementation for findKeyOperatorValueOrder * idk * implement getCclTimeOrder * more impls * another checkpoint * add implementations for all the get methods * add docs * sort * make NoOrder a singleton * doc update * doc update * bug fixes and doc updates * add implementations for select methods * slight refactor * optimization * add performance test and try to run ete test on circle ci * formatting * fix formatting * try again... * nvm * refactor tests slightly * update changelog * fix typo * add Order and Sort classes to ConcourseShell * formatting * add some more unit tests * formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.