Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening Emojiboard does not focus on the input field #62

Closed
hifi opened this issue Aug 17, 2021 · 3 comments · Fixed by #299
Closed

Opening Emojiboard does not focus on the input field #62

hifi opened this issue Aug 17, 2021 · 3 comments · Fixed by #299
Labels
type: improvement Functionality that doesn't exist but can be improved
Milestone
v1.8.0

Comments

@hifi
Copy link

hifi commented Aug 17, 2021 •
edited by ajbura
Loading

Describe the bug

When clicking on the reaction button/emojiboard icon, the focus does note move to the input field of the selector.

Expected behavior

When clicking on the selector, the text input focus should immediately move to the input field of the selector and when the selector is closed (by cancelling or selecting a reaction) the focus should move back to the main input field on the bottom. This ensures seamless experience when reacting to any message during a conversation even while you're writing a message.
@ajbura ajbura added type: bug Something isn't working type: improvement Functionality that doesn't exist but can be improved and removed type: bug Something isn't working labels Aug 30, 2021
ajbura added a commit that referenced this issue Oct 25, 2021
@ajbura
Fix reaction selector doesn't focus msg input (#62)
f544dab 
Signed-off-by: Ajay Bura <ajbura@gmail.com>
@ajbura ajbura closed this as completed Oct 25, 2021
@ajbura ajbura reopened this Oct 25, 2021
@ajbura
Copy link
Member

ajbura commented Oct 25, 2021

Misunderstood this with another bug! :D

So it's not fixed yet.

kfiven pushed a commit that referenced this issue Oct 25, 2021
@ajbura @kfiven
Fix reaction selector doesn't focus msg input (#62)
54dd5a4 
Signed-off-by: Ajay Bura <ajbura@gmail.com>
@kfiven kfiven mentioned this issue Jan 6, 2022
Closed
@jasikpark
Copy link

I'd love to help make this happen!

@ajbura ajbura changed the title Reaction selector does not focus on the input field Opening Emojiboard does not focus on the input field Jan 16, 2022
@kfiven kfiven mentioned this issue Jan 21, 2022
Closed
@ginnyTheCat ginnyTheCat mentioned this issue Feb 3, 2022
Merged
10 tasks
@ajbura ajbura added this to the v1.8.0 milestone Feb 8, 2022
@ajbura ajbura mentioned this issue Feb 9, 2022
Closed
@jasikpark
Copy link

wooo 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: improvement Functionality that doesn't exist but can be improved
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging a pull request may close this issue.

Keyboard focus related bugs ginnyTheCat/cinny
3 participants
@hifi @jasikpark @ajbura