-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix twemoji cdn + add twemoji assets to public #1070
Conversation
Now only the twemoji resources are copied to public at build time, that way we arent shipping any of the twemoji source as well
Preview: https://1070--pr-cinny.netlify.app |
To work this correctly
needs to be replaced by
in GitHub actions files. |
We got build time and bundle size increased with this way. I think we should use a svg sprite maybe with (https://www.npmjs.com/package/@svgmoji/twemoji) or something else? I have done a temp fix in e5e3f5f until we merge this. |
I can change to only copy the svg assets in at build time and use those instead, but looking at file sizes, the svg are actually larger than the 72x72 emoji. All SVG: 8.6MB is the bundle size / build time so significantly larger that it's a blocker? |
@Airyzz Let's just use the mozilla/twemoji-colr font. As discussed in room it won't require crazy setup and will improve the overall DX. |
OK, what should we do for platforms which dont support this font? Fallback to CDN? or just not deal with it for now? |
95% user can render it for other they will get rendered as os default emoji's |
Closing as twemoji has been added as fonts. |
Description
Due to the twemoji cdn outage, we need to use a different cdn. I am also taking this opportunity to include the twemoji assets in the app itself, for use in cinny-desktop.
This adds twitter/twemoji as a submodule in /deps/twemoji
Type of change
Checklist: