Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active private receipt support #1109

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

greentore
Copy link
Contributor

Description

Adds an option to send private read receipts if one's homeserver supports them.
Marked as a draft because the toggle is awkwardly placed in security options.

Fixes #240 when coupled with #1108

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@github-actions
Copy link

github-actions bot commented Mar 30, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link

Preview: https://1109--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@ajbura ajbura self-requested a review March 30, 2023 15:09
Copy link
Member

@ajbura ajbura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. But I am still not sure of if we want people to hide their read receipt but still able to see what others are reading. I believe it will change persons behaviour of being a part of community to being a spy like in community.

@ajbura ajbura mentioned this pull request Aug 2, 2023
Comment on lines +4 to +7
const ReceiptType = {
Read: 'm.read',
ReadPrivate: 'm.read.private',
};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type exists in matrix-js-sdk/lib/@types/read_receipts, why not just use that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hidden Read Receipts
3 participants