Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sidebar on room/space switch #768

Merged
merged 14 commits into from
Aug 20, 2022
Merged

Update sidebar on room/space switch #768

merged 14 commits into from
Aug 20, 2022

Conversation

ajbura
Copy link
Member

@ajbura ajbura commented Aug 19, 2022 •
edited by github-actions bot
Loading

Description

Fixes #353
Fixes #374
Fixes #769

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Preview: https://6300fb5e37e9f8587e6daff2--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@ajbura ajbura merged commit 7e28aa1 into dev Aug 20, 2022
NovaAndrom3da pushed a commit to NovaAndrom3da/neocinny that referenced this pull request Nov 23, 2023
@ajbura @kfiven @NovaAndrom3da
Update sidebar on room/space switch (cinnyapp#768)
c4e51a1 
* Select last room on space/tab change (cinnyapp#353)

* Update sidbar on room select from search (cinnyapp#374)

* Select last room on space/tab change (cinnyapp#353)

* Update sidbar on room select from search (cinnyapp#374)

* Fix wrong space gets selected with some rooms

* Fix auto select room in categorized space

* Fix room remain selected on leave

* Fix leaved room appear in category & search

* Remove globally exposed vars

* Hide pin spaces from home

* Fix selecting dm always open dm tab

* Order category by AtoZ (cinnyapp#769)

Co-authored-by: Krishan <33421343+kfiven@users.noreply.github.com>
@kfiven kfiven deleted the sidebar-update branch May 5, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfiven kfiven kfiven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ajbura @kfiven