Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "Join public room" label to "Explore public rooms" #832

Merged
merged 1 commit into from
Sep 11, 2022
Merged

Change "Join public room" label to "Explore public rooms" #832

merged 1 commit into from
Sep 11, 2022

Conversation

ginnyTheCat
Copy link
Collaborator

@ginnyTheCat ginnyTheCat commented Sep 7, 2022 •
edited by github-actions bot
Loading

Description

Changes the UI label from "Join public room" to "Explore public rooms"

Fixes #787

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Preview: https://832--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@ginnyTheCat ginnyTheCat changed the title Change UI label Change "Join public room" label to "Explore public rooms" Sep 7, 2022
@ajbura ajbura merged commit 0a2cca6 into cinnyapp:dev Sep 11, 2022
@ginnyTheCat ginnyTheCat deleted the explore-rooms branch September 11, 2022 11:28
NovaAndrom3da pushed a commit to NovaAndrom3da/neocinny that referenced this pull request Nov 23, 2023
@ginnyTheCat @NovaAndrom3da
Change UI label (cinnyapp#832)
73a52d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajbura ajbura ajbura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename "Join public room" to "Explore public rooms"
2 participants
@ginnyTheCat @ajbura