Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert tests to munit #368

Merged
merged 2 commits into from
Feb 13, 2023
Merged

convert tests to munit #368

merged 2 commits into from
Feb 13, 2023

Conversation

mzuehlke
Copy link
Contributor

  • replaces scalatest with munit as the test framework
  • uses discipline-munit and munit-cats-effect-3 for better integration
  • the number of tests decreases because doc test for scalatest are split into smaller tests

closes #290
closes #320
closes #340
closes #358

* replaces scalatest with munit as the test framework
* uses discipline-munit and munit-cats-effect-3 for better integration
* the number of tests decreases because doc test for scalatest are split into smaller tests
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2023

Codecov Report

Base: 95.38% // Head: 95.38% // No change to project coverage 👍

Coverage data is based on head (38894ea) compared to base (8f17dca).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #368   +/-   ##
=======================================
  Coverage   95.38%   95.38%           
=======================================
  Files           6        6           
  Lines          65       65           
  Branches        3        3           
=======================================
  Hits           62       62           
  Misses          3        3           
Flag Coverage Δ
2.12.17 95.31% <ø> (ø)
2.13.10 95.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@fthomas fthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @mzuehlke

LGTM, thank you!

@mzuehlke
Copy link
Contributor Author

Thanks for catching the camel case typo 👍

@fthomas fthomas merged commit 0291bbf into circe:master Feb 13, 2023
@mzuehlke mzuehlke deleted the munit branch February 13, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants