Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cats to 1.5.0, Scala 2.13 to 2.13.0-M5 #1015

Merged
merged 12 commits into from
Dec 18, 2018
Merged

Conversation

travisbrown
Copy link
Member

I'll publish this as 0.11.0-M1 tomorrow if everything looks alright.

@codecov-io
Copy link

codecov-io commented Nov 9, 2018

Codecov Report

Merging #1015 into master will increase coverage by 1.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1015     +/-   ##
=========================================
+ Coverage   85.36%   86.47%   +1.1%     
=========================================
  Files          75       75             
  Lines        2392     2669    +277     
  Branches      168      172      +4     
=========================================
+ Hits         2042     2308    +266     
- Misses        350      361     +11
Impacted Files Coverage Δ
.../main/scala/io/circe/jawn/CirceSupportParser.scala 96.77% <ø> (ø) ⬆️
...ain/scala/io/circe/literal/JsonLiteralMacros.scala 61.17% <100%> (ø) ⬆️
...rc/main/scala/io/circe/shapes/SizedInstances.scala 78.57% <0%> (-14.29%) ⬇️
...d/src/main/scala/io/circe/NonEmptySeqDecoder.scala 91.66% <0%> (-8.34%) ⬇️
.../core/shared/src/main/scala/io/circe/Encoder.scala 97.84% <0%> (-0.32%) ⬇️
.../core/shared/src/main/scala/io/circe/Decoder.scala 93.58% <0%> (+0.55%) ⬆️
...rc/main/scala/io/circe/numbers/BiggerDecimal.scala 90.96% <0%> (+0.6%) ⬆️
...les/core/shared/src/main/scala/io/circe/Json.scala 79.61% <0%> (+0.63%) ⬆️
...re/shared/src/main/scala/io/circe/JsonNumber.scala 93.67% <0%> (+3.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a195f2...6576168. Read the comment docs.

@SethTisue
Copy link
Contributor

anything I or other contributors can do to help this move forward?

@SethTisue
Copy link
Contributor

looks like the M5 build is stuck on

[error] coursier.ResolutionException: Encountered 1 error(s) in dependency resolution:
[error]     org.spire-math:jawn-parser_2.13.0-M5:0.13.0:
[error]         not found:
[error]             /home/travis/.ivy2/local/org.spire-math/jawn-parser_2.13.0-M5/0.13.0/ivys/ivy.xml
[error]             https://repo1.maven.org/maven2/org/spire-math/jawn-parser_2.13.0-M5/0.13.0/jawn-parser_2.13.0-M5-0.13.0.pom
[error]             https://oss.sonatype.org/content/repositories/releases/org/spire-math/jawn-parser_2.13.0-M5/0.13.0/jawn-parser_2.13.0-M5-0.13.0.pom
[error]             https://oss.sonatype.org/content/repositories/snapshots/org/spire-math/jawn-parser_2.13.0-M5/0.13.0/jawn-parser_2.13.0-M5-0.13.0.pom

I opened typelevel/jawn#120 on it

@travisbrown
Copy link
Member Author

@SethTisue Yeah, Jawn is the only thing we're waiting on. I've tried pinging @non a number of times over the past couple of months, but haven't heard anything, so I'll probably just fork it once Cats 1.5.0 is ready.

@SethTisue
Copy link
Contributor

perhaps someone watching this repo could submit an M4->M5 upgrade over at https://github.com/non/jawn so that all Erik would need to do is pull publishing levers. M4->M5 is usually an easy bump to do

@travisbrown
Copy link
Member Author

@SethTisue We've had a PR open for a couple of months with no response: typelevel/jawn#117

@travisbrown travisbrown changed the title Update Cats to 1.5.0-RC0 Update Cats to 1.5.0, Scala 2.13 to 2.13.0-M5 Dec 17, 2018
@travisbrown travisbrown merged commit ff2c4b0 into master Dec 18, 2018
@travisbrown travisbrown deleted the update/cats-1.5.0-RC0 branch June 11, 2019 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants