tidied up announcement prefixes, include files, and nested conditions #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trepca
reviewed
Aug 27, 2024
trepca
reviewed
Aug 27, 2024
| @@ -244,7 +245,7 @@ | |||
| (c (list ASSERT_MY_COIN_ID my_coin_id) | |||
| (c | |||
| ; my new balance so someone can check whole ring balance | |||
| (list CREATE_COIN_ANNOUNCEMENT (concat ANN_PREFIX '=' new_amount LAUNCHER_ID)) | |||
| (list CREATE_COIN_ANNOUNCEMENT (concat ANN_PREFIX EQUALS new_amount LAUNCHER_ID)) | |||
There was a problem hiding this comment.
creating a constant for EQUALS only makes sense if you use it more than once
trepca
reviewed
Aug 27, 2024
…y defconst from p2_circuit_treasury.clsp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.