circusd-stats chokes on unix sockets

[lambdafu]

Hi,

circusd-stats is normally started with stdout/stderr closed now, but will try to log with level INFO by default. This causes at least one startup message to be issued. In the current (0.8) implementation, this fails on python 2.7.3 (works fine on 2.7.5). The process exits as soon as it is started, causing it to flatter.

I checked, and between 2.7.3 and 2.7.5 the logging module got a couple of try: blocks around flushing and closing file descriptors. I have not yet debugged this problem fully. As a work around and to confirm the cause of the problem, setting the log-level to CRITICAL by default, it works fine.

I might do some work on this later, just wanted to get the word out as quick as possible.

[tarekziade]

Thanks for this feedback. I guess the safest thing to do is to open stdout/stderr by default for statsd and other processes, and have an option to close them if wanted

[tarekziade]

we found the bug. The stats streamer chokes on unix sockets because it expects regular sockets here: https://github.com/mozilla-services/circus/blob/master/circus/stats/streamer.py#L116

[lambdafu]

Thanks a lot! Works for me now, too.