Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slugify version in setup.py #419

Closed
darodi opened this issue Apr 21, 2022 · 1 comment
Closed

slugify version in setup.py #419

darodi opened this issue Apr 21, 2022 · 1 comment

Comments

@darodi
Copy link
Collaborator

darodi commented Apr 21, 2022

Sorry, now I checked again it seems slugify change version structure recently (from v6). It's weird because I install KCC via PyPi and got error at that line, which means PyPi installs the latest version of slugify instead of respecting the dependency mentioned in requirements.txt.

I found the problem. kcc/setup.py doesn't include the requirements.txt and there is a mismatch.
PyPi version was built using kcc/setup.py.

python-slugify>=1.2.1,<3.0.0

kcc/setup.py

Line 84 in 4ec4c99

'python-slugify>=1.2.1',

something like this would be better in kcc/setup.py

with open("requirements.txt", "r", "utf-8") as f:
    requires = f.readlines()

setuptools.setup(
...

    install_requires=requires,

Originally posted by @darodi in #417 (comment)

@darodi
Copy link
Collaborator Author

darodi commented Apr 21, 2022

Duplicate of #411
Duplicate of #410

@darodi darodi closed this as completed Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant