Implement restart policy for VMs #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkorotkov
reviewed
Apr 24, 2023
internal/worker/vmmanager/vm.go
Outdated
Comment on lines
110
to
112
| vm.logger.Error(err) | ||
| vm.err = err | ||
| vm.Resource.Status = v1.VMStatusFailed |
There was a problem hiding this comment.
Is there a need for errMtx? A VM can only go in the failed state. If setErr will be called several times concurrently, the only race is the vm.err = err assignment which I think is fine not to have a lock on. Doesn't seem like it will make a lot of difference.
There was a problem hiding this comment.
I've updated the code to use atomic.Pointer instead and compare-and-swap operation, check it out.
edigaryev
force-pushed
the
restart-policy
branch
from
116bc6f
to
44b4673
Compare
fkorotkov
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #68.