This repository has been archived by the owner on Oct 20, 2023. It is now read-only.
Sliver 1.6 parser (alpha) and sample dataset #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoldingAustin
requested review from
arniebradfo,
sang2925,
sharplessHQ and
ccarpenter28
GoldingAustin
force-pushed
the
feature/sliver-parser
branch
from
35839ff
to
a324da3
Compare
Catch similar errors in the future
ccarpenter28
approved these changes
Sep 21, 2023
sharplessHQ
approved these changes
Sep 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parser will work for Sliver version 1.6 and up. A starting point for making the parser compatible with version < 1.6 is included through parsing the protobufs of a beacon task input/output.
Updates to our build/release process will come tomorrow in a separate PR. That will include the Sliver parser in the release script