This repository has been archived by the owner on Oct 20, 2023. It is now read-only.
Update Server Terminal Ascii Art #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arniebradfo
commented
Nov 1, 2022
| @@ -31,7 +31,8 @@ const serverStartLogs = async (ctx: ServerMachineContext, clientUrl?: string): P | |||
|
|
|||
| const logLine: string[] = [``]; | |||
|
|
|||
| if (ctx.config.production) logLine.push(asciiArt); | |||
| // if (ctx.config.production) | |||
There was a problem hiding this comment.
@GoldingAustin is this okay, or should it be changed back?
GoldingAustin
approved these changes
Nov 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds RedEye branding the server terminal window
Motivation and context
Branding provides a sense of professionalism, unification, cohesion to the different parts of the RedEye tool.
Testing
Should the art only display in production. I've commented out a conditional in
https-server.tsthat limits this.Screenshots