Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard should reflect the user role #569

Merged
merged 8 commits into from
Sep 5, 2024

Conversation

jayjaybunce
Copy link
Collaborator

@jayjaybunce jayjaybunce commented Aug 27, 2024

🗣 Description

  • Updated header to include the formatted user role
  • Removed old styling to rely solely on MUI
  • Updated RegionUsers to display Dashboard
    • Global Admin Dashboard
    • Regional Admin Dashboard

💭 Motivation and context

🧪 Testing

📷 Screenshots (if appropriate)

Screenshot 2024-08-27 at 1 58 05 PM Screenshot 2024-08-27 at 1 58 29 PM

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Copy link
Contributor

@ameliav ameliav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me when I switch to global admin, regional admin, and standard user.

When I am a global view user, it says "Regional Admin" . I'm assuming it should say "Global View User". @schmelz21 ?

@jayjaybunce
Copy link
Collaborator Author

Works for me when I switch to global admin, regional admin, and standard user.

When I am a global view user, it says "Regional Admin" . I'm assuming it should say "Global View User". @schmelz21 ?

Resolved with recent commit.

@ameliav ameliav self-requested a review August 29, 2024 17:17
Copy link
Contributor

@ameliav ameliav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmelz21
Copy link
Collaborator

Screenshot 2024-08-29 at 3 43 26 PM

@stewartl97 - In mobile (sm) mode are we satisfied with not displaying the UserType?

@stewartl97
Copy link

@schmelz21 Yes, we can revisit this later, but for this particular issue we can hold off on displaying usertype.

@chrtorres chrtorres self-requested a review August 30, 2024 13:44
@schmelz21 schmelz21 merged commit af11133 into develop Sep 5, 2024
11 of 15 checks passed
@schmelz21 schmelz21 deleted the 420-dashboard-should-reflect-the-user-role branch September 5, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants